Differences From Artifact [0696e641e7]:
- File src/platform/windows/OFProcess.m — part of check-in [5ca0376aa3] at 2020-02-29 16:09:46 on branch trunk — Move OFProcess to platform subdirectory (user: js, size: 8506) [annotate] [blame] [check-ins using] [more...]
To Artifact [75eaa2091a]:
- File
src/platform/windows/OFProcess.m
— part of check-in
[67df0aa735]
at
2020-04-24 22:42:55
on branch trunk
— OFProcess: Initialize to invalid handles first
The reason for this is that if anything fails during init, close is
called on dealloc and we want it to be in a sane state for that. (user: js, size: 8581) [annotate] [blame] [check-ins using]
| ︙ | ︙ | |||
115 116 117 118 119 120 121 122 123 124 125 126 127 128 | PROCESS_INFORMATION pi; STARTUPINFOW si; void *pool; OFMutableString *argumentsString; of_char16_t *argumentsCopy; size_t length; sa.nLength = sizeof(sa); sa.bInheritHandle = TRUE; sa.lpSecurityDescriptor = NULL; if (!CreatePipe(&_readPipe[0], &_readPipe[1], &sa, 0)) @throw [OFInitializationFailedException exceptionWithClass: self.class]; | > > > | 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 | PROCESS_INFORMATION pi; STARTUPINFOW si; void *pool; OFMutableString *argumentsString; of_char16_t *argumentsCopy; size_t length; _process = INVALID_HANDLE_VALUE; _readPipe[0] = _writePipe[1] = NULL; sa.nLength = sizeof(sa); sa.bInheritHandle = TRUE; sa.lpSecurityDescriptor = NULL; if (!CreatePipe(&_readPipe[0], &_readPipe[1], &sa, 0)) @throw [OFInitializationFailedException exceptionWithClass: self.class]; |
| ︙ | ︙ |